search

FanTranslatorsInternational / Kuriimu2

Kuriimu is a general purpose game translation project manager and toolkit for authors of fan translations and game mods.
GNU General Public License v3.0
311 stars 56 forks source link

Add Sonic Generations text plugin #144

Closed LITTOMA closed 3 years ago

LITTOMA commented 3 years ago

128

onepiecefreak3 commented 3 years ago

Interesting to see how the current API is already used. It isn't considered final at all, so it will probably still change/expanded upon. Seeing your plugin I can see the need for initializing a TextEntry with just a decoded text already for various reasons. As well as retrieving just the decoded text without any processing done to minimize boilerplate, as seen in L53 of SharpMsg.cs.

If I merge the plugin now, would you allow me to make changes on it as I further design the TextAPI?

LITTOMA commented 3 years ago

If I merge the plugin now, would you allow me to make changes on it as I further design the TextAPI?

Sure, you can change it to suit your needs.