search

FanTranslatorsInternational / Kuriimu2

Kuriimu is a general purpose game translation project manager and toolkit for authors of fan translations and game mods.
GNU General Public License v3.0
324 stars 59 forks source link

Cannot open most text files from titles beyond Mario & Luigi Dream Team (Kuriimu1) #23

Open LolHacksRule opened 4 years ago

LolHacksRule commented 4 years ago

Describe the bug Most text files (MSBT) extracted from Mario and Luigi RPGs beyond 4 (Dream Team) and the remasters fail to be read by Kuriimu.

To Reproduce Steps to reproduce the behavior:

  1. Extract game data from ROM
  2. Navigate to 'Msg/XX_xx'
  3. Drag text file on Kuriimu
  4. Error is shown and the file doesn't load

Expected behavior File opens properly without problems aside from control code issues.

Screenshots If applicable, add screenshots to help explain your problem.

The problematic text files all output this message:

image

And some output this message when the file is extracted completely fine from the ROM and read by the game correctly.

image

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Other tools for MSBT work with a portion (Reloaded)/all of them (Toolbox/msyt) but have the same control code issues with the formatting. The staff at Karameru's Discord recommended me to start an issue here instead of Kuriimu's repo. Any plans to fix it before porting the text plugin?

Problematic text files (Superstar Saga, US English)

Problematic text files (Paper Jam [Retail Demo/Kiosk], EU English)

IcySon55 commented 4 years ago

The Superstar Saga files look fairly normal so there might be a bug introduced recently. For now, try an older version of Kuriimu 1.

LolHacksRule commented 4 years ago

Ok thanks

kenshiisod commented 3 years ago

I think both msyt (msbt-rs) and Kuriimu assume that the padding character (0xAB) will exist before the section but for these particular MSBTs null padding is used.

kenshiisod commented 3 years ago

I fixed this for msbt-rs by not relying on 0xAB and instead skipping to the nearest 0x16. https://github.com/ascclemens/msbt-rs/pull/4

MarioForever91 commented 2 years ago

What exactly is the version of Kuriimu1 that works with the superstar saga msbt files? I have tested all versions from 1.0.9 to the latest and none have worked. Would it be possible for someone to point me to one that works? NOTE: Sorry for my English. I don't speak English well.