search

FanTranslatorsInternational / Kuriimu2

Kuriimu is a general purpose game translation project manager and toolkit for authors of fan translations and game mods.
GNU General Public License v3.0
308 stars 56 forks source link

Update BLN plugin archive naming with archive IDs #238

Closed jonko0493 closed 2 years ago

jonko0493 commented 2 years ago

Based on original research into Suzumiya Haruhi no Heiretsu, the MCB archives contained in BLNs actually have IDs that should be used as their "names" as that ID is how the engine decides which archive to load. See the debug logging below:

image

This value matches the value of unk1, which I have renamed to id. Additionally, I have replaced the archive name with this ID displayed in hexadecimal.

cc/ @obluda3 @onepiecefreak3

obluda3 commented 2 years ago

Could we keep both names then? Something like id_index.

jonko0493 commented 2 years ago

Totally doable, of course, but what's the reasoning? Backwards-compatibility with the old numbering system?

obluda3 commented 2 years ago

Pretty much.

jonko0493 commented 2 years ago

Done!

IcySon55 commented 2 years ago

Let me know when you guys think this is ready to go.

jonko0493 commented 2 years ago

For what it's worth, I would say this is ready to go. Minimal impact and adds useful information.

jonko0493 commented 2 years ago

@IcySon55 obluda has approved by way of reaction haha. I'd say we should merge now.