Fanatics88 / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Summary #9

Open chelBot opened 7 years ago

chelBot commented 7 years ago

Grade: Meets Expectations

Summary: Good job completing this project and submitting it on time! You have learned to work locally in your text editor and that is a big step. I was pleased to see a ​Doctype Declaration ​at the top of your HTML and your file structure was well organized. Your heading hierarchy was coherent and I was pleased to see the inclusion of a charset within your head. Your code was well-formatted throughout and I liked your use of divs to give the page a bit more structure.

The main issue I saw was the element you tried to nest within your p tags: \<des class="price">Starting at $3.00 / brush.\</h>" . The opening tag (which is not a correct tag name) does not match the classing tag (which is also not a correct tag name). A better tag to use here would be the span tag.

For future projects, please download all images and use relative paths to link to them rather than absolute paths. While this isn’t strictly necessary, I do encourage it as new developers often struggle with navigating directory structures and this is an important concept to get right. For more info, please read this section: https://internetingishard.com/html-and-css/links-and-images/#absolute-relative-and-root-relative-links

Finally, I encourage you to start thinking about web accessibility. This is something you will learn more about in week 7 but for a quick overview: ​https://www.codecademy.com/articles/accessibility

Overall, you did an excellent job here. Keep up the hard work!

Fanatics88 commented 7 years ago

Thanks a lot for your review. I didn't think about the span tag who is a great solution for this project ! For the future I will download all my images in a repertory for more accessibility and structures. I'm going to read all of the differents links you gave me. Again thank you and have a good day !

Fanatics88 commented 7 years ago

And all the modifications are done. Thanks again.