search

FancyMcPlugins / FancyHolograms

FancyHolograms is a simple, lightweight and fast hologram plugin using display entities
https://modrinth.com/plugin/fancyholograms
MIT License
81 stars 28 forks source link

Use org.bukkit.Color instead of TextColor in Text Hologram Background #82

Closed UsainSrht closed 1 month ago

UsainSrht commented 2 months ago

I'd recommend saving background field in only one way instead of transparent, green, #RRGGBB If that's okay I can create another pr for that.

OakLoaf commented 1 month ago

Do you think you could rename this or move the persistent related commits into a separate branch/pr. After you've done that I can review the PR

OakLoaf commented 1 month ago

Just making note that this PR would resolve https://github.com/FancyMcPlugins/FancyHolograms/pull/33

UsainSrht commented 1 month ago

Do you think you could rename this or move the persistent related commits into a separate branch/pr. After you've done that I can review the PR

Yeah I accidentally committed persistent holograms here too, I'll create two different branches for these two features.

UsainSrht commented 1 month ago

separated as #95 & #96