FancyMcPlugins / FancyHolograms

FancyHolograms is a simple, lightweight and fast hologram plugin using display entities
https://modrinth.com/plugin/fancyholograms
MIT License
93 stars 29 forks source link

Bedrock Text + Paperweight clean setup #87

Closed Olzie-12 closed 2 months ago

Olzie-12 commented 4 months ago

Hello, this pull request fixes the paperweight issue of setting up the versions in multiple modules. instead setup the version once with apply false. Updated paper weight to 1.7.1

Bedrock text, server owners now may specify bedrock_text in holograms.yml, and if a player is a geyser user. it'll show this text. Please note I haven't created any command implementations, and adding, removing and inserting is still changing the base text. Maybe something like this should make it implemented to make it more completed.

Antbrix commented 4 months ago

I would like to see this merged, it would be a very nice feature to have.

Agaloth commented 4 months ago

I would like to see this merged, it would be a very nice feature to have.

This is still being tested by me as right now it's having some trouble figuring out if a player is on bedrock or not, once fixed we'll update the PR

Olzie-12 commented 4 months ago

Unfortunately yeah some servers have floodgate installed on velocity, and then using geyser standalone so then the server would not even know if the player is a bedrock player. I don't know much about geyser so please suggest a better idea for this kinda setup

OakLoaf commented 4 months ago

Unfortunately yeah some servers have floodgate installed on velocity, and then using geyser standalone so then the server would not even know if the player is a bedrock player. I don't know much about geyser so please suggest a better idea for this kinda setup

The only solution I can think of for this PR is to use floodgate. Floodgate can (and should) be put on all backend servers, the majority of plugins that offer bedrock support will do this through floodgate, if a server owner doesn't want floodgate on their backend servers that is on them and will cause them to lose features in a handful of bedrock compatible plugins.

Olzie-12 commented 4 months ago

Unfortunately yeah some servers have floodgate installed on velocity, and then using geyser standalone so then the server would not even know if the player is a bedrock player. I don't know much about geyser so please suggest a better idea for this kinda setup

The only solution I can think of for this PR is to use floodgate. Floodgate can (and should) be put on all backend servers, the majority of plugins that offer bedrock support will do this through floodgate, if a server owner doesn't want floodgate on their backend servers that is on them and will cause them to lose features in a handful of bedrock compatible plugins.

I completely agree, the way of checking of the players name is not nice whatsoever. I'll make sure to revert back to floodgate and make sure that people use floodgate if they want this implementation

OakLoaf commented 4 months ago

I'll have another look at this in the morning :)

OakLoaf commented 4 months ago

This pr got me inspired to work on my placeholder plugin, it's just a basic PlaceholderAPI add-on that adds a config file for defining text that bedrock players and java players will see.

I was wondering if this would be more suitable for you guys?

Olzie-12 commented 4 months ago

This pr got me inspired to work on my placeholder plugin, it's just a basic PlaceholderAPI add-on that adds a config file for defining text that bedrock players and java players will see.

I was wondering if this would be more suitable for you guys?

i don't know why i didn't think of this from the start, in fact i think a lot of servers would benefit from this as its not just limited to the fancy holograms plugin.

OakLoaf commented 4 months ago

This pr got me inspired to work on my placeholder plugin, it's just a basic PlaceholderAPI add-on that adds a config file for defining text that bedrock players and java players will see. I was wondering if this would be more suitable for you guys?

i don't know why i didn't think of this from the start, in fact i think a lot of servers would benefit from this as its not just limited to the fancy holograms plugin.

I did mention this to someone before the pr was made but I guess it didn't make it to you. Nonetheless I do believe that people would still appreciate and use this PR.

OakLoaf commented 2 months ago

I'm going to close up this PR due to it being inactive for a couple months