search

FancyMcPlugins / FancyNpcs

FancyNpcs is a simple, lightweight and fast npc plugin using packets
https://modrinth.com/plugin/fancynpcs
MIT License
102 stars 23 forks source link

[Feature Request] Skin Mirroring + URL Skin Application #10

Closed R00tB33rMan closed 1 year ago

R00tB33rMan commented 1 year ago

Skin mirroring would be a cool feature. An example of implementing this onto the plugin's existing system would be: /npc skin Test

In addition, maybe implementing skin URL support would be a cool feature if this is also not too challenging. Here's an example: /npc skin Test https://google.com/skin/8hjHTD6gydyhgjd7 or just /npc skin test {URL}

Zemux1613 commented 1 year ago

Hey @R00tB33rMan what types of url do you want to support? Currently the plugin obfuscates url calls to make the system easy to use.

matipoirierg commented 1 year ago

Hi quick question, is sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream() related from this patch?

Zemux1613 commented 1 year ago

Hello @matipoirierg, all changes of this patch can be seen in this link. HttpsURLConnectionImpl#getInputStream is not affected by this patch.

lsyk4 commented 1 year ago

Question. It's possible to set a Image as NPC skin? I mean when I write /npc skin mynpc https://i.ibb.co/8dNRmfZ/chica.png the NPC must take the skin from the image

OliverSchlueter commented 1 year ago

Question. It's possible to set a Image as NPC skin? I mean when I write /npc skin mynpc https://i.ibb.co/8dNRmfZ/chica.png the NPC must take the skin from the image

Hey, it is not possible yet (that's why the issue is still open).

OliverSchlueter commented 1 year ago

Now it is possible, see 09c2edd41948ac01ba16bd44318d4a1392a1f0a6 (will be included in the next version)