FancyMcPlugins / FancyNpcs

FancyNpcs is a simple, lightweight and fast npc plugin using packets
https://modrinth.com/plugin/fancynpcs
MIT License
102 stars 23 forks source link

Implement dynamic skin mirroring #30

Closed Yive closed 5 months ago

Yive commented 11 months ago

Allows for NPCs to mirror the skin of the player that the packet is being sent to. This probably could've been added to the skin command, but this way was more straight forward.

I've only tested this against 1.20.1 and an online mode server. example

luisBazanDev commented 5 months ago

Does the creator intend to add this change? or why has this pr been open for so long?

Yive commented 5 months ago

Does the creator intend to add this change? or why has this pr been open for so long?

The conflicts were likely preventing it from being accepted as this PR is quite old. Ended up resolving those along with making the PR support 1.20.2/1.20.4.

I had to add in a username verification check as however many months ago, I ran into an issue with geyser players getting kicked or something similar.