search

FancyMcPlugins / FancyNpcs

FancyNpcs is a simple, lightweight and fast npc plugin using packets
https://modrinth.com/plugin/fancynpcs
MIT License
100 stars 23 forks source link

FancyNPCs causes netty errors #37

Closed ghost closed 10 months ago

ghost commented 10 months ago

After running plugin for 12+ hours with average 20-30 players online, that saw 2-3 NPCs and changed worlds to without NPCs (game world) and to world with that same NPCs (lobby) pretty quickly, I have the following error when trying to join the server (NPCs are visible right after joining)

[21:43:06] [Server thread/INFO]: ESpinach[/REDACTED] logged in with entity id 858307 at ([world]8.5, 201.0, 8.5)
[21:43:06] [Server thread/INFO]: ESpinach lost connection: Internal Exception: io.netty.handler.codec.EncoderException: java.lang.IllegalArgumentException: unable to fit 3310206 into 3

No additional logs or stacktrace were printed and I'm pretty sure it's caused by this plugin because quick /fancynpcs reload from console fixed the problem.

OliverSchlueter commented 10 months ago

Which version of FancyNpcs and Paper do you use?

ghost commented 10 months ago

Latest Purpur 1.20.1 (build 2044) and FancyNpcs 2.0.1.

OliverSchlueter commented 10 months ago

Try to use v2.0.2 (https://hangar.papermc.io/Oliver/FancyNpcs/versions/2.0.2)

ghost commented 10 months ago

Still occurs on 2.0.2.1 and still temporarily fixed by reloading. I noticed two things.

  1. The value that it's trying to "fit into 3" increases every join, it tried to fit 6942846 first time and 6944136 second time: 
    [02:17:28] [Server thread/INFO]: ESpinach[/REDACTED] logged in with entity id 1490096 at ([world]8.5, 204.0, 8.5)
[02:17:28] [Server thread/INFO]: ESpinach lost connection: Internal Exception: io.netty.handler.codec.EncoderException: java.lang.IllegalArgumentException: unable to fit 6942846 into 3
[02:17:50] [User Authenticator #295/INFO]: UUID of player ESpinach is f810c323-991a-35ac-a6f3-d5f030301a7e
[02:17:51] [Server thread/INFO]: ESpinach[/REDACTED] logged in with entity id 1490117 at ([world]8.5, 204.0, 8.5)
[02:17:51] [Server thread/INFO]: ESpinach lost connection: Internal Exception: io.netty.handler.codec.EncoderException: java.lang.IllegalArgumentException: unable to fit 6944136 into 3
  2. It only affects versions 1.19.3 - 1.20.1. (I have ViaVersion and if I join using 1.19.2 and below, I don't see any errors, but NPCs are not visible too, though they're normally visible from 1.19.2 and below)