search

FancyMcPlugins / FancyNpcs

FancyNpcs is a simple, lightweight and fast npc plugin using packets
https://modrinth.com/plugin/fancynpcs
MIT License
100 stars 23 forks source link

feat(NPC): on cooldown interaction message hide feature #66

Closed yukisnowflake closed 6 months ago

OliverSchlueter commented 6 months ago

I think a config option would be better. Something like "disable_interaction_cooldown_message"

yukisnowflake commented 6 months ago

I think a config option would be better. Something like "disable_interaction_cooldown_message"

Not tested, but done

OakLoaf commented 6 months ago

Wouldn't it make more sense to instead add a way for all messages to not be sent? Quite commonly plugins allow setting a message as blank "" to have it not being sent

This can be checked with String#isBlank()

OliverSchlueter commented 6 months ago

Wouldn't it make more sense to instead add a way for all messages to not be sent? Quite commonly plugins allow setting a message as blank "" to have it not being sent

This can be checked with String#isBlank()

Yes but for now it should work

OliverSchlueter commented 6 months ago

@yukisnowflake make sure your code compiles next time. There is no FancyNpcsPlugin#getFancyNpcConfig