FancyThemes / wp-advanced-excerpt

A WordPress plugin that allows you to control the appearance of post excerpts
GNU General Public License v3.0
23 stars 7 forks source link

Code / file structure cleanup? #10

Closed aprea closed 10 years ago

aprea commented 10 years ago

Am noticing that the code isn't exactly written using WordPress best practices (tab sizes, brackets, etc)

Just wondering if you wanted me to clean it up at all?

Same thing with the directory structure, everything is plonked into the root folder.

aprea commented 10 years ago

Actually, on second thought, this seems like a no-brainer, it's really difficult to work with the code in it's current state.

I'm just going to go ahead and do this.

bradt commented 10 years ago

When you do cleanup tabs and spacing, just make sure it's in a commit without any other code changes. And don't do it manually. Use https://github.com/welovewordpress/SublimePhpTidy or https://github.com/scribu/wp-phptidy instead.

aprea commented 10 years ago

Will do, thanks.

bradt commented 10 years ago

Thanks for making lots of well-labelled commits. Easily digested and much appreciated.