Update googlesearch - Githubissues

FanfictionBot / reddit-ffn-bot

A reddit auto reply bot.

53 stars 18 forks source link

Update googlesearch #116

Closed derpyherp closed 4 years ago

derpyherp commented 4 years ago

Right now bot works with story IDs but not if titles are used (e.g. linkffn(Some Text Here)). It's because google search is broken.

Update to latest version of googlesearch (https://github.com/MarioVilas/googlesearch) and titles work again (tested).

tusing commented 4 years ago

Good idea! Updating to the latest version of googlesearch fixes things.

I think we can clean things up a bit:

Delete all googlesearch related files (__init__.py, google/*)
Add google to requirements.txt
Change the import in ffn_bot/cache.py to from googlesearch import search

Could you please update the PR with these changes?

tusing commented 4 years ago

Awesome!

  File "./ffn_bot/cache.py", line 7, in <module>
    from google import search
ModuleNotFoundError: No module named 'google'

The only change needed now is to fix the import:

--- a/ffn_bot/cache.py
+++ b/ffn_bot/cache.py
@@ -3,8 +3,7 @@ import time
 from collections import OrderedDict

 from requests import get
-
-from google import search
+from googlesearch import search