Sanity and Edit Checks - Githubissues

FanfictionBot / reddit-ffn-bot

A reddit auto reply bot.

53 stars 18 forks source link

Sanity and Edit Checks #88

Closed tusing closed 9 years ago

tusing commented 9 years ago

I think we should add two things:

Sanity Checks will make sure that the bot has replied to every FanfictionBot call. This will require changing from using checked_comments.txt to checking the replies to comments calling the bot. If replies to a comment contain FanfictionBot as an author, the bot will not respond. Otherwise, the bot will create a reply.
Edit Checks will update FanfictionBot replies if the parent comment has updated their submission.

A fundamental change in this is that _we won't be using checked_comments.txt_ to make sure we've replied to a comment - instead, we'll check the replies to every comment that calls the bot, instead.

StuxSoftware commented 9 years ago

It would be an idea. But doesn't it generate a lot of traffic?

tusing commented 9 years ago

It does, and minimizing that would be something to consider. However, it has the potential to make the bot better - bot calls won't fail anymore and people won't have to call for parent if they edit their comment. Any ideas?

StuxSoftware commented 9 years ago

Well, I still think that the bot should be manually asked to evaluate parent posts. Other than that, well I think we should not use edit checks. Doing so might break someones workflow, especially of those who do nut know much about formatting in reddit and don't want to have tags and calls appear in their post.

I think the ffnbot!parent keeps this somewhat friendly for non technically inclined users. But otherwise, I would totally go for this change as it drops the checked comments.txt

tusing commented 9 years ago

Was looking into this a bit more. There are far too many edge cases to make the bot self-correcting. I do not have the time to isolate and solve for every edge case that might happen, so I don't see this happening any time soon.