search

FangShancheng / ABINet

Read Like Humans: Autonomous, Bidirectional and Iterative Language Modeling for Scene Text Recognition
Other
429 stars 72 forks source link

Bad requirements.txt #15

Open stevenwalton opened 3 years ago

stevenwalton commented 3 years ago

Hi, I noticed that the requirements.txt file is no longer valid. Some of the versions do not exist in pip. I'm noticing that torch==1.1.0, torchvision==0.3.0, and fastai==1.0.60. Is there a reason these are so old? Current torch version is 1.9.0, torchvision is 0.10.0 and fastai is 2.4. I have some of the code working with these newer versions. The other parts I'm working through (I'm at a syntax error right now).

FangShancheng commented 3 years ago

Hi, I noticed that the requirements.txt file is no longer valid. Some of the versions do not exist in pip. I'm noticing that torch==1.1.0, torchvision==0.3.0, and fastai==1.0.60. Is there a reason these are so old? Current torch version is 1.9.0, torchvision is 0.10.0 and fastai is 2.4. I have some of the code working with these newer versions. The other parts I'm working through (I'm at a syntax error right now).

This repository works still well on Newer torch versions (i.e, 1.6 and 1.7). However, the current torch version 1.9.0 is not tested. It would be helpful to provide the error log for further supporting newer version @stevenwalton

stevenwalton commented 3 years ago

I don't have problems with the newer repos. But what I'm trying to say is that the requirements file doesn't work because those versions of those modules no longer are accessible from pip, so you error out. To solve this problem either another version needs to be selected or the versioning needs to be removed. The examples in the README work fine, it was other parts that weren't working and I have since moved on to another OCR system.