search

Fanghua-Yu / SUPIR

SUPIR aims at developing Practical Algorithms for Photo-Realistic Image Restoration In the Wild. Our new online demo is also released at suppixel.ai.
http://supir.xpixel.group/
Other
4.33k stars 378 forks source link

Incorrect install instructions + missing instructions #12

Open UpscaleAnon opened 8 months ago

UpscaleAnon commented 8 months ago

The install instructions on the main page seems to be incorrect, it tells you to use python 3.8 with "conda create -n SUPIR python=3.8 -y" and then pip install -r requirements.txt But so many of the requirements require a higher python version

image

I also tried without using Conda, python 3.10.6, but still getting errors and can't run test.py

image

I tried using Conda with 3.9 and I get way less errors, but it's still complaining about triton, and it still doesn't work. But maybe because I don't have the 5 models you linked.

image

The instructions also show 5 dependant models, but it doesn't show how to install them, nor what parts exactly to download on those 5 linked pages. It would be nice if the setup included a python script that automatically downloads the required models and puts them where they need to be.

Akarity commented 8 months ago

Same here, I just tried to follow the readme instructions and install a few minutes ago but got a whole bunch of errors like that on the previous post.