search

Fannon / search-bookmarks-history-and-tabs

Browser extension to search and navigate browser tabs, local bookmarks and history.
MIT License
172 stars 8 forks source link

Open URL in current tab is not working #112

Closed garulovilla closed 6 months ago

garulovilla commented 6 months ago

Hi,

I have been looking for an extension that let me search in bookmarks and tabs, and yours is the perfect extension 👌🏽, thanks a lot.

I noticed that, If I have more than 1 window open, the current tab (in my active window where the extension was activated) is not changing if I press Shift + Enter. Instead, the active tab from the other window (maybe some window in the background) is changed.

I think maybe adding the option currentWindow: true to query tabs in file searchView.js make the trick.

Regards.

Fannon commented 6 months ago

Hi @garulovilla - thanks for the kind words and reporting the issue (directly with a solution :))!

Yes, it looks like I overseen adding this option on that place. Just had a look and in a different place I already had added the currentWindow: true. Didn't notice the issue because I usually only have one browser window open at a time.

I'll try the fix for a few days and then create a new bugfix release!

Fannon commented 6 months ago

Ok, I created #113 that will hopefully fix this. Releasing this to the extension stores will however take a few days.

If you notice any more issues, please let me know :)

garulovilla commented 6 months ago

Thanks @Fannon 😄.