search

Fannon / search-bookmarks-history-and-tabs

Browser extension to search and navigate browser tabs, local bookmarks and history.
MIT License
172 stars 8 forks source link

multiple languages support? #94

Closed ojarux closed 1 year ago

ojarux commented 1 year ago

I think it is a very useful add-on. However, This add-on seems to be limited to single-byte characters.

  1. Is it possible to support multiple languages? image

  2. It would be useful to be able to open a new page without closing the search results with a middle click. Thanks!

ojarux commented 1 year ago

Almost solved,

  1. I can use double-byte character in "PRECISE" mode
  2. Ctrl+Enter works well in this situation
Fannon commented 1 year ago

Hi @ojarux : Could you try this option? The problem is that the fuzzy search library by default does not work well with CJK languages. You can also switch to precise search only, it should handle this situation fine (and if not, please report so I can look into how to fix it :) )

# make CJK chars work for fuzzy search
uFuzzyOptions:
  interSplit: (p{Unified_Ideograph=yes})+

See also this issue: https://github.com/Fannon/search-bookmarks-history-and-tabs/issues/87

Fannon commented 1 year ago

I've seen that you use the hybrid search mode. Does it give you any benefits? It was added at a time when the fuzzy search was not giving as relevant results as nowadays, so combining it with precise seemed a good workaround. But now fuzzy search got better and I'm not sure whether it makes sense to keep hybrid around.

ojarux commented 1 year ago

Thank you for your prompt reply. As I already mentioned, I was able to avoid the problem by setting the search mode to "PRECISE". I also tried uFuzzyOptions and it works, however the result with or without fuzzy search are the same. I think it is the best of the similar add-ons! If I may make a request, it would be great if the display space could be widened and the font size could be changed to improve the listability.

Fannon commented 1 year ago

Thanks for the kind words and feedback!

Good point about increasing size in general. I'll think about that how that can be done best, as a browser extensions popup are not really "responsive" like you can make a website responsive. Right now it's a very fixed layout and it would be some effort to customize that. But I can think about making it generally a bit bigger.

Fannon commented 1 year ago

I've reopened this issue because for the average user, it's unrealistic they'll look for and apply a custom setting to fix this.

But I also didn't want to apply the ideagraph setting generally, so I created a PR where this is only added when necessary.