search

Fannovel16 / ComfyUI-Frame-Interpolation

A custom node set for Video Frame Interpolation in ComfyUI.
MIT License
506 stars 48 forks source link

RIFE Crashing silentlty #36

Closed phreax closed 11 months ago

phreax commented 11 months ago

It used to work fine, but suddenly RIFE is crashing silently after a while. Using the latest commit with latest ComfyUI, with rife49.pth checkpoint (I tried 46, 47 as well) running on a T4 in google colab Input has only 120 frames.

Output is:

got prompt
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
^C
aiXander commented 11 months ago

Yeah having the same issue, I can see the VRAM slowly going up while RIFE is running until it crashes due to OOM. Feel like the clearing cache isnt actually working maybe?

aiXander commented 11 months ago

Ok, I think the problem is that the code here only clears the gpu memory cache and not the VRAM cache.

I think the only solution for longer videos is to save the interpolated frames to disk instead of keeping them in memory.

aiXander commented 11 months ago

Created a tiny pull request with some improvements: https://github.com/Fannovel16/ComfyUI-Frame-Interpolation/pull/37