search

Fannovel16 / ComfyUI-Frame-Interpolation

A custom node set for Video Frame Interpolation in ComfyUI.
MIT License
457 stars 45 forks source link

Is this FiLM VFI running out of memory? #39

Open TijuanaKez opened 9 months ago

TijuanaKez commented 9 months ago

This seems to quit about %20 of the time (FiLM VFI) Without an error message, I'm assuming it's being killed due to running our of ram (even though I have 24GB GPU and 64GB system)

Loading 1 new model
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Final clearing cache...
Comfy-VFI: Done cache clearing
Killed

Sucks because It looses the whole queue. Are there any other logs specifically for this custom node?

SnoopKing796 commented 8 months ago

same happening to me, following up may find answer

TijuanaKez commented 5 months ago 
Comfy-VFI: Clearing cache... Done cache clearing
Comfy-VFI: Clearing cache... Done cache clearing
Comfy-VFI: Clearing cache... Done cache clearing
Comfy-VFI: Clearing cache... Done cache clearing
Comfy-VFI: Clearing cache... Done cache clearing
Comfy-VFI: Clearing cache... Done cache clearing
Comfy-VFI: Final clearing cache... Done cache clearing
Killed

Man this really blows. I have a 3090 24GB and the frames I'm pushing to it are 1344x896, I wouldn't have thought that would be too much to ask. It wouldn't be so bad if it just killed the current item in the queue and kept going like when other custom nodes crash. But when you come back after 5 hours to find the whole queue has been erased due to FILM VFI killing the whole ComfyUI process, it's cry-worthy. Such a shame because the pixel flow between frames seems more natural than what you get with things like Topaz Video.

TijuanaKez commented 4 months ago

Any chance there could be some kind of memory estimation followed by a check of available ram and if 24GB VRAM and 64GB system ram really isn't enough, it could just abort this node's process with an error to the console, and move on to the next task in the queue.

I feel like something else may be wrong here though, watching the ram useage with nvtop, I think there is actually enough ram while the interpolate node is processing the frames.

It seems to kill the process (and loose the entire Comfy queue) when its finished.

Amit30swgoh commented 2 months ago

yeah it sucks

TijuanaKez commented 2 months ago

I think this is actually more of a system ram thing. It seems to happen when Comfy wants to swap out the VFI model at the end and swap back in the diffusion models for the next job in the queue. In my case when I installed Ubuntu knowing I had 64GB system ram I made the swap file small, thinking my system should never really need it. Also, the recommended 2x system ram for a swap = 128GB which seemed like a big sacrifice of space on the 1TB NMVe.

Turns out Comfy wants stupid amount of RAM with complex workflows involving lots of different kinds of models.

Installing a bigger NMVe and devoting 128GB to the swap file seems to have alleviated the issue. So far so good anyway.