Open Webifi opened 9 months ago
There seems to be more issues with tight_bboxes, where if it doesn't detect hands it will error out.
Error occurred when executing MeshGraphormer-DepthMapPreprocessor:
'NoneType' object is not subscriptable
File "E:\ComfyUI_windows_portable\ComfyUI\execution.py", line 155, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "E:\ComfyUI_windows_portable\ComfyUI\execution.py", line 85, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "E:\ComfyUI_windows_portable\ComfyUI\execution.py", line 78, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_controlnet_aux\node_wrappers\mesh_graphormer.py", line 78, in execute
hand_bboxes = info["abs_boxes"]
My guess is when hands aren't detected, that key isn't created. But then based on depth and original work even if there are no hands detected.
I have same issue with the following workflow: https://openart.ai/workflows/datou/hand-refiner/XNcfT4iDYnQImq2UC3lP
I'm running into the same issue. It should not crash but simply output empty segments if there are no hands, so that subsequent nodes just work on empty lists and do nothing instead of crashing themselves. I hope I can create a fix and would post a PR if that helps... if @Fannovel16 themselves do not want to create one that is...
My PR #396 fix has been merged, thanks @Fannovel16. It should fix this issue.
When using tight_bboxes for the mask image, bbox mask for a hand is too close to the edge (left edge tested) the bbox will not show on the mask.
Using based_on_depth with a high Mask Expand does work, though not ideal in some cases.