Fannovel16 / comfyui_controlnet_aux

ComfyUI's ControlNet Auxiliary Preprocessors
Apache License 2.0
1.65k stars 158 forks source link

[FeatureRequest] New preprocessor Depth and Normal Metric3D #343

Closed sdbds closed 1 month ago

sdbds commented 1 month ago

https://github.com/YvanYin/Metric3D

wibur0620 commented 1 month ago

https://github.com/TheMistoAI/ComfyUI-Anyline

wibur0620 commented 1 month ago

https://github.com/TheMistoAI/ComfyUI-Anyline

https://github.com/TheMistoAI/MistoLine

Fannovel16 commented 1 month ago

@sdbds

Fannovel16 commented 1 month ago

@wibur0620

Fannovel16 commented 1 month ago

RepeatImageBatch is unneccessary. It's there for testing multiple batches

wibur0620 commented 1 month ago

https://github.com/Fannovel16/comfyui_controlnet_aux/assets/131615326/42df065a-094f-4699-a79c-3cb2dd22a358

RepeatImageBatch is unneccessary. It's there for testing multiple batches

This is strange. This node is indeed confirmed to be yours, but the way it opens feels very strange to me. I did not uninstall the ComfyUI-Anyline plugin before updating your plugin. I wonder if this is the reason for the issue?

wibur0620 commented 1 month ago

image

Fannovel16 commented 1 month ago

@wibur0620 Ah I forgot to change the category

Fannovel16 commented 1 month ago

Fixed https://github.com/Fannovel16/comfyui_controlnet_aux/commit/0c00bb6c4ceff64dd806d82d37b390914f214daf

wibur0620 commented 1 month ago

image

wibur0620 commented 1 month ago

image

wibur0620 commented 1 month ago

image Is the metric_depth_vit_giant2_800k.pth model necessary? I noticed that this model is very large, and it was not used in the official demo of Metric3D. image

wibur0620 commented 1 month ago

image image

wibur0620 commented 1 month ago

model_path is D:\AI\ComfyUI\custom_nodes\comfyui_controlnet_aux\ckpts\JUGGHM/Metric3D\metric_depth_vit_small_800k.pth using MLP layer as FFN Loading weight 'D:\AI\ComfyUI\custom_nodes\comfyui_controlnet_aux\ckpts\JUGGHM/Metric3D\metric_depth_vit_small_800k.pth' Successfully loaded weight: 'D:\AI\ComfyUI\custom_nodes\comfyui_controlnet_aux\ckpts\JUGGHM/Metric3D\metric_depth_vit_small_800k.pth' model_path is D:\AI\ComfyUI\custom_nodes\comfyui_controlnet_aux\ckpts\JUGGHM/Metric3D\metric_depth_vit_small_800k.pth using MLP layer as FFN Loading weight 'D:\AI\ComfyUI\custom_nodes\comfyui_controlnet_aux\ckpts\JUGGHM/Metric3D\metric_depth_vit_small_800k.pth' Successfully loaded weight: 'D:\AI\ComfyUI\custom_nodes\comfyui_controlnet_aux\ckpts\JUGGHM/Metric3D\metric_depth_vit_small_800k.pth' Prompt executed in 3.16 seconds

Fannovel16 commented 1 month ago

@wibur0620 Giant2 is added for versatility. I agree that the difference between small and large is already marginal tho. Gonna make the small one as the default

Fannovel16 commented 1 month ago

Guess that there is no more problem

https://github.com/Fannovel16/comfyui_controlnet_aux/commit/ab0705c9e3ae50e3cd58f339578013241acf4659

wibur0620 commented 1 month ago

image This issue seems to remain unresolved; there is a bug in the deep preprocessing.

Fannovel16 commented 1 month ago

@wibur0620 Wdym?

wibur0620 commented 1 month ago

@wibur0620 Wdym?

After processing through this node, the resulting image is completely white and lacks any depth information, regardless of which model I choose.

Fannovel16 commented 1 month ago

@wibur0620 Wdym?

After processing through this node, the resulting image is completely white and lacks any depth information, regardless of which model I choose.

What about normal?

sdbds commented 1 month ago

@wibur0620 Wdym?

After processing through this node, the resulting image is completely white and lacks any depth information, regardless of which model I choose.

same problem.

Fannovel16 commented 1 month ago

@sdbds @wibur0620 example_metric3d

sdbds commented 1 month ago

@sdbds @wibur0620 example_metric3d

image

it works now

rethink-studios commented 1 month ago

Just downloaded and tried to use the Metric3D-DepthMapPreprocessor and got this error. I created the folders needed, downloaded the file, and I still get the error

image

image

image

rethink-studios commented 1 month ago

image

I got the same error (10:45 CST)

rethink-studios commented 1 month ago

link changed?? Here's the working link: https://huggingface.co/JUGGHM/Metric3D/resolve/main/metric_depth_vit_giant2_800k.pth?download=true

kagevazquez commented 1 month ago

Error occurred when executing Metric3D-NormalMapPreprocessor:

Failed to find function: controlnet_aux.metric3d.mono.model.backbones.vit_giant2_reg

Screenshot 2024-05-22 164130

Screenshot 2024-05-22 164622