search

Fannovel16 / comfyui_controlnet_aux

ComfyUI's ControlNet Auxiliary Preprocessors
Apache License 2.0
1.65k stars 158 forks source link

add edge-drawing parameter-free (EDPF) preprocessor #356

Closed geroldmeisinger closed 1 month ago

geroldmeisinger commented 1 month ago

adds an edge-drawing parameter-free (EDPF) preprocessor for the following controlnet: https://civitai.com/models/149740 This is similar to ControlNet Canny but uses a modern algorithm for edge-detection which requires no parameter tuning (Canny was invented in 1986, Edge Drawing in 2012).

please note: this requires opencv-contrib as outlined here https://github.com/Fannovel16/comfyui_controlnet_aux/discussions/355 it seems to work when i add opencv-contrib in requirements last (after mediapipe and albumentations add opencv). however it make break if any other custom node installs opencv afterwards. i don't know what the best way to handle this is yet.

Fannovel16 commented 1 month ago

@geroldmeisinger I'll be a bit harsh here. I'll only add EPDF preprocessor if it has a numpy implementation. Changing current cv2 to opencv-contrib may break this node pack's compatibility.

geroldmeisinger commented 1 month ago

thanks for the quick answer and considering. I understand. I'll look into it. it may take a while.