Fansana / floofstation1

GNU Affero General Public License v3.0
15 stars 68 forks source link

Round Start Security Magbots #345

Closed ProphetCrow closed 2 days ago

ProphetCrow commented 2 weeks ago

Description

This is an expansion / overwrite to https://github.com/Fansana/floofstation1/pull/335 . I attempted to reach out to the original creator over discord, however, they appear to have left the community and the message did not go thru.

The overall goal of this PR is to make security magboots more accessible round start. This PR aims to put a pair of magboots in every security hardsuit filled locker, including Corpsmen, Warden, HoS, and the normal security suit storage lockers.

Why? I believe security should have this resource round start. Delta-P from spacing and lubebombs can sometimes be impossible to deal with as security, and other departments that have access to space suits, such as salvage and engineering, already start with magboots in their lockers. I dont believe its a logical stretch to give it to security, who may have one of the highest needs for this kind of item. As it currently stands, these items are locked behind a techfab recipe, and that puts the urgency to print these boots in the hands of the warden or head of security, depending on the map. These players may not even realize these items are even in the game, or you may often run into games where there is no warden or a HoS; making ready access to these items impossible. In addition, DeltaV released this version of the magboots on their server to a widely positive review. My PR expands upon this release and reuses the sprite from their fork, which is my resprite that I personally made to match the uniforms of the security officers.

Potential concerns: I attempted to add a delayuse component on the boots to prevent people from robustly spamming the slip-proof feature while minimizing the 20% movement speed reduction, but I wasnt able to get it to work at my junior level of programming so I opt'd to leave it alone. I was able to identify it could be related to the ToggleClothing system but its currently above my skill level. Seeing how this playerbase is more MRP, I personally dont believe we will run into a situation of a player abusing the slip proof function of the magboots to metagame security that often, but I do know this was a potential balance concern. Overall, I believe the addition of these boots are a net positive to the security department. I believe their introduction into suitstorage lockers is well overdue.


image image image


:cl: Crow

github-actions[bot] commented 2 weeks ago

RSI Diff Bot; head commit de9569fcc8fd648546268e50afe9b034d342c1a5 merging into 3b2d14aacdba3a35811dfb91f6583598f177271c This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Floof/Clothing/Shoes/Boots/combatMagboots.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-FEET-vox | ![](https://raw.githubusercontent.com/Fansana/floofstation1/3b2d14aacdba3a35811dfb91f6583598f177271c/Resources/Textures/Floof/Clothing/Shoes/Boots/combatMagboots.rsi/equipped-FEET-vox.png) | ![]() | Removed | equipped-FEET | ![](https://raw.githubusercontent.com/Fansana/floofstation1/3b2d14aacdba3a35811dfb91f6583598f177271c/Resources/Textures/Floof/Clothing/Shoes/Boots/combatMagboots.rsi/equipped-FEET.png) | ![]() | Removed | icon-on | ![](https://raw.githubusercontent.com/Fansana/floofstation1/3b2d14aacdba3a35811dfb91f6583598f177271c/Resources/Textures/Floof/Clothing/Shoes/Boots/combatMagboots.rsi/icon-on.png) | ![]() | Removed | icon | ![](https://raw.githubusercontent.com/Fansana/floofstation1/3b2d14aacdba3a35811dfb91f6583598f177271c/Resources/Textures/Floof/Clothing/Shoes/Boots/combatMagboots.rsi/icon.png) | ![]() | Removed | inhand-left | ![](https://raw.githubusercontent.com/Fansana/floofstation1/3b2d14aacdba3a35811dfb91f6583598f177271c/Resources/Textures/Floof/Clothing/Shoes/Boots/combatMagboots.rsi/inhand-left.png) | ![]() | Removed | inhand-right | ![](https://raw.githubusercontent.com/Fansana/floofstation1/3b2d14aacdba3a35811dfb91f6583598f177271c/Resources/Textures/Floof/Clothing/Shoes/Boots/combatMagboots.rsi/inhand-right.png) | ![]() | Removed | on-equipped-FEET-vox | ![](https://raw.githubusercontent.com/Fansana/floofstation1/3b2d14aacdba3a35811dfb91f6583598f177271c/Resources/Textures/Floof/Clothing/Shoes/Boots/combatMagboots.rsi/on-equipped-FEET-vox.png) | ![]() | Removed | on-equipped-FEET | ![](https://raw.githubusercontent.com/Fansana/floofstation1/3b2d14aacdba3a35811dfb91f6583598f177271c/Resources/Textures/Floof/Clothing/Shoes/Boots/combatMagboots.rsi/on-equipped-FEET.png) | ![]() | Removed | on-inhand-left | ![](https://raw.githubusercontent.com/Fansana/floofstation1/3b2d14aacdba3a35811dfb91f6583598f177271c/Resources/Textures/Floof/Clothing/Shoes/Boots/combatMagboots.rsi/on-inhand-left.png) | ![]() | Removed | on-inhand-right | ![](https://raw.githubusercontent.com/Fansana/floofstation1/3b2d14aacdba3a35811dfb91f6583598f177271c/Resources/Textures/Floof/Clothing/Shoes/Boots/combatMagboots.rsi/on-inhand-right.png) | ![]() | Removed

Resources/Textures/Floof/Clothing/Shoes/Boots/magboots-security.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-FEET | ![]() | ![](https://raw.githubusercontent.com/ProphetCrow/floofstation1234/de9569fcc8fd648546268e50afe9b034d342c1a5/Resources/Textures/Floof/Clothing/Shoes/Boots/magboots-security.rsi/equipped-FEET.png) | Added | icon-on | ![]() | ![](https://raw.githubusercontent.com/ProphetCrow/floofstation1234/de9569fcc8fd648546268e50afe9b034d342c1a5/Resources/Textures/Floof/Clothing/Shoes/Boots/magboots-security.rsi/icon-on.png) | Added | icon | ![]() | ![](https://raw.githubusercontent.com/ProphetCrow/floofstation1234/de9569fcc8fd648546268e50afe9b034d342c1a5/Resources/Textures/Floof/Clothing/Shoes/Boots/magboots-security.rsi/icon.png) | Added | inhand-left | ![]() | ![](https://raw.githubusercontent.com/ProphetCrow/floofstation1234/de9569fcc8fd648546268e50afe9b034d342c1a5/Resources/Textures/Floof/Clothing/Shoes/Boots/magboots-security.rsi/inhand-left.png) | Added | inhand-right | ![]() | ![](https://raw.githubusercontent.com/ProphetCrow/floofstation1234/de9569fcc8fd648546268e50afe9b034d342c1a5/Resources/Textures/Floof/Clothing/Shoes/Boots/magboots-security.rsi/inhand-right.png) | Added | on-equipped-FEET | ![]() | ![](https://raw.githubusercontent.com/ProphetCrow/floofstation1234/de9569fcc8fd648546268e50afe9b034d342c1a5/Resources/Textures/Floof/Clothing/Shoes/Boots/magboots-security.rsi/on-equipped-FEET.png) | Added | on-inhand-left | ![]() | ![](https://raw.githubusercontent.com/ProphetCrow/floofstation1234/de9569fcc8fd648546268e50afe9b034d342c1a5/Resources/Textures/Floof/Clothing/Shoes/Boots/magboots-security.rsi/on-inhand-left.png) | Added | on-inhand-right | ![]() | ![](https://raw.githubusercontent.com/ProphetCrow/floofstation1234/de9569fcc8fd648546268e50afe9b034d342c1a5/Resources/Textures/Floof/Clothing/Shoes/Boots/magboots-security.rsi/on-inhand-right.png) | Added

Edit: diff updated after de9569fcc8fd648546268e50afe9b034d342c1a5

Fansana commented 1 week ago

I'm personally against this, the shoes at this point offer an armor bonus which would make them a must take. If they are available round start they have to lose this bonus.

fenndragon commented 1 week ago

Normally I would say either it's magboots or armor. But no other boot in the game to my knowledge has any form of armor. I agree with fasana on this one

BluCottonCandy commented 1 week ago

The thing is security should not be wearing Magboots/hard suits (excluding warden and HOS) unless they are required.

The armor they add is insignificant, and if we tried to add security gas masks (which do also have armor) you all would have the same complaint, yet no one's ever had an issue with them as they truly add no bonus.

I am all for this PR because not having them round start is stupid.

fenndragon commented 1 week ago

The thing is security should not be wearing Magboots/hard suits (excluding warden and HOS) unless they are required.

The armor they add is insignificant, and if we tried to add security gas masks (which do also have armor) you all would have the same complaint, yet no one's ever had an issue with them as they truly add no bonus.

I am all for this PR because not having them round start is stupid.

we would not have the same complaint, other armored leg pieces have been denied for the same reason, and actually having magboots and hardsuits is not actually against any rules or guidelines, it's just not general practice for any of the above to have hardsuits when in code green.

ProphetCrow commented 1 week ago

I'm personally against this, the shoes at this point offer an armor bonus which would make them a must take. If they are available round start they have to lose this bonus.

The armor bonus was stripped, Ive overwritten the original PR entirely. Ill double check the code though.

Edit: The armor bonus was effectively removed by deleting Resources/Prototypes/Floof/Entities/Clothing/Shoes/Combatmags.yml and replacing it with Resources/Prototypes/Floof/Entities/Clothing/Shoes/magboots.yml

My version does not provide an armor bonus and is identical to normal magnetic boots, down to the material cost.

image

VividPups commented 1 week ago

My discord vividpups if you would like to reach me. I will join the community back soon (discord-wise) I am the OG creator for the boots

Yes I was thinking that Combat magboots could be used for an Highcost starting option but I didn't want to get into Loadout stuff. I will probably make an Captain one soon.

VividPups commented 1 week ago

And please do not removed the SESWC

VividPups commented 1 week ago

also have this been tested on VOX so that it lines up correctly with them

Fansana commented 3 days ago

Dunno why the test is complaining about the saltern docking but I think it doesn't matter.