search

Fansana / floofstation1

GNU Affero General Public License v3.0
14 stars 67 forks source link

Consent UI Generated #373

Open FoxxoTrystan opened 10 hours ago

FoxxoTrystan commented 10 hours ago

Description

This PR does not include a changlog as its does not change anything gameplay wise.

For devs, this makes so consent options in the UI are auto-generated by the prototype making it more easy to handle consent options as its generated correctly, also untangle some tiny messes and make the UI way more pretty.

Media

![image](https://github.com/user-attachments/assets/b96fa2f8-e910-475d-9621-4a4337c136d9) ![image](https://github.com/user-attachments/assets/e19ab687-d660-4634-afe8-c3622bc28d4c)

Memeji commented 7 hours ago

A change log should still be necessary for visual/backend UI changes. Those aren't just for the players.

Changelogs are specifically for players.

FoxxoTrystan commented 7 hours ago

No changelogs are needed as this changes nothing for the players directly.

sleepyyapril commented 1 hour ago

Is the idea for this being able to do something like _consentManager.GetConsentStatus("key"), similar to ccvars?

FoxxoTrystan commented 1 hour ago

Is the idea for this being able to do something like _consentManager.GetConsentStatus("key"), similar to ccvars?

This only changes Consent UI Aspect, not serverside, currently you need to do this:

_consent.HasConsent(uid, "key")

sleepyyapril commented 1 hour ago

Is the idea for this being able to do something like _consentManager.GetConsentStatus("key"), similar to ccvars?

This only changes Consent UI Aspect, not serverside, currently you need to do this:

_consent.HasConsent(uid, "key")

Right, but the goal is similar, which is what I meant. Amazing work.