FantasticFiasco / action-update-license-year

GitHub Action that in a pull request updates the copyright year(s) in your license file.
Apache License 2.0
59 stars 2 forks source link

Is there a specific reason to leave out merging of the branch? #213

Closed utkarshsethi closed 2 years ago

utkarshsethi commented 2 years ago

Is your feature request related to a problem? Please describe. Having to manually merge branch after license update.

Describe the solution you'd like Auto merge and deletion of the branch

Describe alternatives you've considered I've written additional job to merge and delete the branch

Can submit a pr to include in this. or if it's left out a reason, a documentation entry to guide others looking for this.

github-actions[bot] commented 2 years ago

Hi there and welcome to this repository!

A maintainer will be with you shortly, but first and foremost I would like to thank you for taking the time to report this issue. Quality is of the highest priority for us, and we would never release anything with known defects. We aim to do our best but unfortunately you are here because you encountered something we didn't expect. Lets see if we can figure out what went wrong and provide a remedy for it.

FantasticFiasco commented 2 years ago

Hi @utkarshsethi!

The reasoning for excluding the proposed feature was because I didn't think anyone trusted the codebase to automatically merge the created PR. But here you are 😄

How did you solve it? Does it require changes to the codebase or did you chained additional steps in the workflow to merge the PR and then delete the branch?

utkarshsethi commented 2 years ago

Hi @utkarshsethi!

The reasoning for excluding the proposed feature was because I didn't think anyone trusted the codebase to automatically merge the created PR. But here you are 😄

So you can maybe just give it as a suggestion in the README. Which will offer the users the option to choose.

How did you solve it? Does it require changes to the codebase or did you chained additional steps in the workflow to merge the PR and then delete the branch?

I just chained gh cli steps

        # Auto Merge license -> master
      - uses: actions/checkout@master

        #merge and delete
      - name: Auto Merge license -> master
        env:
          GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
        run: |
          gh pr checkout license
          gh pr merge -d -m
FantasticFiasco commented 2 years ago

@utkarshsethi thanks for the contribution!

utkarshsethi commented 2 years ago

@FantasticFiasco Thanks for the app, will save a ton of time later.