Closed utkarshsethi closed 2 years ago
Hi there and welcome to this repository!
A maintainer will be with you shortly, but first and foremost I would like to thank you for taking the time to report this issue. Quality is of the highest priority for us, and we would never release anything with known defects. We aim to do our best but unfortunately you are here because you encountered something we didn't expect. Lets see if we can figure out what went wrong and provide a remedy for it.
Hi @utkarshsethi!
The reasoning for excluding the proposed feature was because I didn't think anyone trusted the codebase to automatically merge the created PR. But here you are 😄
How did you solve it? Does it require changes to the codebase or did you chained additional steps in the workflow to merge the PR and then delete the branch?
Hi @utkarshsethi!
The reasoning for excluding the proposed feature was because I didn't think anyone trusted the codebase to automatically merge the created PR. But here you are 😄
So you can maybe just give it as a suggestion in the README. Which will offer the users the option to choose.
How did you solve it? Does it require changes to the codebase or did you chained additional steps in the workflow to merge the PR and then delete the branch?
I just chained gh cli steps
# Auto Merge license -> master
- uses: actions/checkout@master
#merge and delete
- name: Auto Merge license -> master
env:
GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
run: |
gh pr checkout license
gh pr merge -d -m
@utkarshsethi thanks for the contribution!
@FantasticFiasco Thanks for the app, will save a ton of time later.
Is your feature request related to a problem? Please describe. Having to manually merge branch after license update.
Describe the solution you'd like Auto merge and deletion of the branch
Describe alternatives you've considered I've written additional job to merge and delete the branch
Can submit a pr to include in this. or if it's left out a reason, a documentation entry to guide others looking for this.