FantasticFiasco / aws-signature-version-4

The buttoned-up and boring, but deeply analyzed, implementation of SigV4 in .NET
Apache License 2.0
76 stars 18 forks source link

Use space character as the separator for user-agent header instead of comma #1156

Closed mungojam closed 1 month ago

mungojam commented 2 months ago

Description

This fixes a signing error that occurs with multiple user agent parts, e.g. Mozilla/5.0 Gecko/geckotrail

Checklist

FantasticFiasco commented 1 month ago

These changes looks awesome, added tests and everything!

I'll merge the pr right now, and then tomorrow I'll include it in a new release. Thank you so much for the contribution!

mungojam commented 1 month ago

Thanks for the kind words 🙂, always happy to contribute to such a useful and unique library