search

FantasticFiasco / aws-signature-version-4

The buttoned-up and boring, but deeply analyzed, implementation of SigV4 in .NET
Apache License 2.0
77 stars 19 forks source link

Should we skip the User-Agent header? #1208

Open FantasticFiasco opened 18 hours ago

FantasticFiasco commented 18 hours ago

Describe the bug

As described a review remark of #1207, let's analyze if we should skip the User-Agent header instead having special support for it in the codebase (#1155).

mungojam commented 18 hours ago

I wouldn't call it a workaround, it was changing it to implement the user agent spec. But if it can be skipped altogether in the signature then that's a good result

FantasticFiasco commented 9 hours ago

You are correct, my intention was not to downplay this contribution. Bad wording on my part, I'll update my text.

FantasticFiasco commented 9 hours ago

As it currently is worded, do you think it makes more sense, or can it be improved?

mungojam commented 9 hours ago

As it currently is worded, do you think it makes more sense, or can it be improved?

It's all good now thanks 🙂