Open 0xced opened 1 year ago
Hi @0xced!
I've given this some thought, weighting pros and cons. On the positive side it means that I can delete code, that I don't have to manage it anymore. That is great! On the negative side I lose control and introduce risk. Looking at the changes in the specific files, there hasn't been any for a really long time. That diminishes the value of this change. Also, dependencies comes at a cost. For a user this means taking a dependency not on one NuGet package but instead two. And although Dependabot and Renovate are fantastic tools for dependency management, I must believe that many companies host their source on-prem, where these tools cannot run. As a user there's also is the fear on the compatibility matrix between the two tools.
Let's leave this PR open, but I won't merge it until I get more feedback or encounter a problem with my implementation that would be solved by your implementation. I wish you all the best of luck in your open source endeavour!
Description
Recommend using Serilog.Formatting.Log4Net instead.
Serilog.Formatting.Log4Net
is better that the providedLog4jTextFormatter
andLog4netTextFormatter
classes as it is configurable and well documented.Disclaimer: I am the author of
Serilog.Formatting.Log4Net
. 😉Checklist