FantasticFiasco / serilog-sinks-udp

A Serilog sink sending UDP packages over the network.
Apache License 2.0
30 stars 15 forks source link

feat: create configuration option for broadcasting #175

Closed dnatov closed 1 year ago

dnatov commented 1 year ago

Description

I encountered some issues with multiple network interfaces in which broadcast UDP messages would not work. I found that changing the UDPClient.EnableBroadcast property to true had fixed all of my issues. In our project I made the change but wanted to also provide this feature for other people to use.

The changes were simply adding an optional boolean option enableBroadcast on the static LoggerConfiguration class. This option is passed into the UDPClientWrapper where it is set on the client.

Checklist

FantasticFiasco commented 1 year ago

Hi @dnatov and thanks for the pr! I'll look into the issue in the upcoming days.

FantasticFiasco commented 1 year ago

These changes look good! I'll merge them and create a new release.

Thanks for the contribution!

FantasticFiasco commented 1 year ago

A NuGet package has now been released with your changes.

dnatov commented 1 year ago

Thanks for the release! Happy to contribute!