search

FantasyFootballAnalytics / ffanalytics

ffanalytics R package
http://ffanalytics.fantasyfootballanalytics.net/
163 stars 100 forks source link

Update source_scrapes.R #123

Closed TheMathNinja closed 2 years ago

TheMathNinja commented 2 years ago

I think this should make FFToday scrape complete.

TheMathNinja commented 2 years ago

The current function was leaving pages out of FFToday scrape. This should fix it.

atungate commented 2 years ago

Ah, I see you also added QB and TE to 2 pages (I didn't on my most recent commit). It would probably be too much for the weekly scrapes (weeks 1 - 18) but we can add logic to accommodate it for the season-long.

I lean slightly against it because the players on page 2 for QB and TE have such low projections; and, in-general, I'de like to limit the number of pages we hit on a site for any given-scrape. But, what do you think? I think an argument could be made for including it because those players would be aggregated in the projections_table() function. Even so, lean towards omitting but want to hear what you think.

TheMathNinja commented 2 years ago

I don't have strong opinions about what happens on offense here. My main opinion is that all 3 pages be included for IDP, since IDP projections are notorious for high variance, since player roles in the defense are less known/consistent than on offense. I'm a completionist at heart and like it being there on offense also, but I'm fine with it just being 3 pages for IDP and keeping QB and TE to 1 page each.

atungate commented 2 years ago

Sounds good--thanks, Mike! We will re-evaluate in the future if the need arises.