search

FantasyTeddy / QuantumFlux

Wireless RF for Minecraft
5 stars 4 forks source link

Two or more players with activated magnets can dupe item #12

Closed takarabako closed 4 years ago

takarabako commented 5 years ago

What is happening When two or more players with activated magnets are near each other, items dropped near them will get picked by both of them, results in duping the dropped items.

How to reproduce

  1. Tell two players go near each other and activate their magnets.
  2. One of them drop an item of any kind on the ground.

Expected behavior One of the player gets the item, not both.

Version: quantumflux-1.12.2-2.0.16 Mod pack: FTB Presents Stoneblock 2

Checking itemtoGet.isDead here should be enough to fix this. If the item is already picked up by someone, setDead() will be called.

Yunus1903 commented 5 years ago

I can confirm, found out about it in the StoneBlock 2 modpack

FantasyTeddy commented 5 years ago

Thank you for reporting this issue and even providing a solution. I made your suggested changes and released a new version. Can you please check if the bug is gone?