search

FantasyTeddy / QuantumFlux

Wireless RF for Minecraft
5 stars 4 forks source link

Willing to add my magnet mod's code to this magnet. #18

Closed TheUnderTaker11 closed 5 years ago

TheUnderTaker11 commented 5 years ago

Feature context I will make the magnet work as a bauble, will add an anti-magnet block to cancel out the suction for items above and below it. Also might as well add the chat message telling you if the magnet has been enabled or disabled.

Reasoning Will overall greatly improve the magnet from this mod. As the magnet stands it's not really that practical since there are no blocks to cancel out the magnet.

My main question is if you want me to add that code from my mod over, cause it won't take too long for me to make a PR with my stuff added. (When I get around to actually doing it.)

FantasyTeddy commented 5 years ago

Thank you very much for your offer. I would gladly accept any PR you issue for this.

This would be my wish-list:

TheUnderTaker11 commented 5 years ago

Was not aware of this mods existence, I would highly suggest linking to that mod on your curse page or somehow telling people who use your magnet about it! Is an awesome mod I've never seen before, and it is honestly needed to make your magnet practical.

On Thu, Feb 21, 2019, 9:57 AM Matthias Baer <notifications@github.com wrote:

Thank you very much for your offer. I would gladly accept any PR you issue for this.

This would be my wish-list:

  • Making the magnet work as a bauble would be great (in any slot).
  • I don't really like the idea of adding an anti-magnet block to this mod... using a mod like Demagnetize https://minecraft.curseforge.com/projects/demagnetize is my preferred way of achieving this.
  • Feel free to add a chat message for enabling/disabling the magnet.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/FantasyTeddy/QuantumFlux/issues/18#issuecomment-466053797, or mute the thread https://github.com/notifications/unsubscribe-auth/AQFzuWuiKHKEf00echE0MyXPBBfro4Vkks5vPsHMgaJpZM4bFpXv .