Add checking consistency at the end of the scenario

thaarok commented 1 year ago

Updates Norma "run" to include a final "check" phase verifying network invariant including:

all node (that are still running at the end) reached the same block height (+/- 1 block)
all nodes report the same state hash for all their blocks

(More checks to be added later.)

thaarok commented 1 year ago

@HerbertJordan I have prepared refactoring, which merges RpcClient interface introduced in this PR (based on rpc.Client) with RpcClient interface which have already existed in apps (based on ethclient.Client).

As this introduces an additional wrapper to suit both interfaces by one object, I keep this in a standalone branch for now:

https://github.com/Fantom-foundation/Norma/compare/jkalina/checking...jkalina/checking-refac-rpcclient

Let me know if you prefer to include it into this PR, or if I should do it as a follow-up pull request.

HerbertJordan commented 1 year ago

@hkalina I like the change in your branch and would suggest that we first merge in the RpcClient cleanup and then rebase this PR on top of it. Would this be hard to do?

thaarok commented 1 year ago

Rebased by suggestion. For green tests, fix #156 should be merged first.

Fantom-foundation / Norma

Add checking consistency at the end of the scenario #154