Modification to match YML definition - Githubissues

Fantom-foundation / Norma

Integration project of Carmen and Tosca

GNU Lesser General Public License v3.0

2 stars 9 forks source link

Modification to match YML definition #228

Closed rpl-ffl closed 3 months ago

rpl-ffl commented 3 months ago

n.Client.Type is now used to determined if a node is a validator
- n.Client.Type is now checked if the value is one of validator, rpc, observer. Defaults to observer if unspecified
- n.Client.Type now completely replaces scenario.num_validator. scenario.num_validator now deprecated and an error is thrown when checking the scenario. Additionally, cli run flag --num-validator now prints that it is deprecated and that it will have no effect on the scenario.
```
// the following creates 4 nodes, not 8 nodes.
duration: 100
// num_validator: 4 // THIS IS NOW INVALID
node:
   - name: validator // This is used to expressed previously-used num_validator: 4
     instances: 4
     client:
         type: validator
```
- Internally the expression static validator and dynamic validator is now used. static validator lasts the entire duration of the scenario while dynamic validator does not. Any mention of the two terms to end user are accompanied with explanation.
n.Timer is now configurable
- Current takes the following timer event start, end, kill, restart
- Performs a cursory check if the timer event makes sense, e.g. start -> start should give an error.
- Automatic reconciliation with n.Start and n.End
```
node:
  start: 0
  end: 10
  timer:
      0: start // added automatically from start
      10: end // added automatically from end
```

rpl-ffl commented 3 months ago

Rapol to remove entirely the NumValidator expression rather than reconciling.