search

Fantom-foundation / go-lachesis

aBFT consensus for permission-less networks
https://fantom.foundation
MIT License
220 stars 77 forks source link

Sporadic failure of TestPoset/Check_consensus test #210

Closed Maxime2 closed 4 years ago

Maxime2 commented 5 years ago

Describe the bug The TestPoset/Check_consensus test fails sporadically:

time="2019-06-06T11:38:05+10:00" level=warning msg="event e01 had received already, so rejected"
time="2019-06-06T11:38:05+10:00" level=warning msg="event c11 had received already, so rejected"
time="2019-06-06T11:38:05+10:00" level=warning msg="event d01 had received already, so rejected"
time="2019-06-06T11:38:05+10:00" level=warning msg="event D12 had received already, so rejected"
time="2019-06-06T11:38:05+10:00" level=warning msg="event a01 had received already, so rejected"
time="2019-06-06T11:38:05+10:00" level=warning msg="event c01 had received already, so rejected"
time="2019-06-06T11:38:05+10:00" level=warning msg="event b01 had received already, so rejected"
--- FAIL: TestPoset (7.00s)
    --- FAIL: TestPoset/Check_consensus (0.03s)
        poset_test.go:73: 
                Error Trace:    poset_test.go:73
                Error:          Not equal: 
                                expected: &posposet.Block{Index:0x4b, Events:hash.EventsSlice{hash.Event{0x21, 0xc9, 0xa5, 0xd4, 0x3d, 0xe0, 0x7d, 0xb4, 0x86, 0x77, 0xd6, 0x96, 0xa7, 0x88, 0xc, 0x2, 0x2f, 0xe9, 0xdd, 0x5, 0xd1, 0x77, 0xa7, 0x7e, 0x60, 0xdc, 0xda, 0xc9, 0xe0, 0x25, 0xfd, 0x0}, hash.Event{0xfe, 0xaa, 0xef, 0xae, 0x8a, 0xae, 0x36, 0xac, 0x21, 0xc6, 0xd9, 0xcb, 0x5f, 0xc5, 0x80, 0x6c, 0x95, 0xf1, 0x3a, 0x9a, 0x12, 0x43, 0x33, 0xb6, 0xe4, 0x7e, 0xe3, 0x5f, 0x18, 0xfe, 0xbc, 0xdd}}}
                                actual  : &posposet.Block{Index:0x4b, Events:hash.EventsSlice{hash.Event{0x21, 0xc9, 0xa5, 0xd4, 0x3d, 0xe0, 0x7d, 0xb4, 0x86, 0x77, 0xd6, 0x96, 0xa7, 0x88, 0xc, 0x2, 0x2f, 0xe9, 0xdd, 0x5, 0xd1, 0x77, 0xa7, 0x7e, 0x60, 0xdc, 0xda, 0xc9, 0xe0, 0x25, 0xfd, 0x0}, hash.Event{0x46, 0x5a, 0x26, 0x59, 0x48, 0x91, 0x56, 0xe3, 0x88, 0x5e, 0x4d, 0xb7, 0xbe, 0x59, 0xe5, 0x14, 0x62, 0xb9, 0x78, 0xa9, 0x14, 0xd6, 0xb8, 0xeb, 0x44, 0xd8, 0x83, 0xff, 0x85, 0x38, 0x6f, 0x9f}, hash.Event{0xfe, 0xaa, 0xef, 0xae, 0x8a, 0xae, 0x36, 0xac, 0x21, 0xc6, 0xd9, 0xcb, 0x5f, 0xc5, 0x80, 0x6c, 0x95, 0xf1, 0x3a, 0x9a, 0x12, 0x43, 0x33, 0xb6, 0xe4, 0x7e, 0xe3, 0x5f, 0x18, 0xfe, 0xbc, 0xdd}, hash.Event{0xc8, 0x76, 0x8a, 0xbe, 0x34, 0xa0, 0xd2, 0x59, 0x36, 0xc2, 0x9, 0xbc, 0x47, 0x6f, 0x10, 0x2d, 0xa9, 0x5f, 0xfa, 0x14, 0x33, 0xa7, 0x4a, 0x49, 0xae, 0xf9, 0x47, 0x40, 0x6d, 0xbe, 0xdf, 0x3a}, hash.Event{0x72, 0xe2, 0x28, 0xc8, 0x4c, 0x42, 0xad, 0xfa, 0x47, 0xa9, 0x4, 0xd3, 0x5c, 0x65, 0xb6, 0x16, 0xe4, 0xa7, 0x47, 0x68, 0x16, 0xa4, 0x24, 0x96, 0x4c, 0x52, 0xa2, 0xa5, 0xac, 0x7b, 0x5a, 0x8d}}}

                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -2,5 +2,8 @@
                                  Index: (uint64) 75,
                                - Events: (hash.EventsSlice) (len=2) {
                                + Events: (hash.EventsSlice) (len=5) {
                                   (hash.Event) (len=32) a078,
                                -  (hash.Event) (len=32) d078
                                +  (hash.Event) (len=32) b078,
                                +  (hash.Event) (len=32) d078,
                                +  (hash.Event) (len=32) c078,
                                +  (hash.Event) (len=32) e078
                                  }
                Test:           TestPoset/Check_consensus
                Messages:       block
FAIL
FAIL    github.com/Fantom-foundation/go-lachesis/src/posposet   7.280s
time="2019-06-06T14:23:54+10:00" level=warning msg="event b01 had received already, so rejected"
time="2019-06-06T14:23:54+10:00" level=warning msg="event c01 had received already, so rejected"
time="2019-06-06T14:23:54+10:00" level=warning msg="event e01 had received already, so rejected"
--- FAIL: TestPoset (6.19s)
    --- FAIL: TestPoset/Check_consensus (0.01s)
        poset_test.go:73: 
                Error Trace:    poset_test.go:73
                Error:          Not equal: 
                                expected: &posposet.Block{Index:0x1a, Events:hash.EventsSlice{hash.Event{0x2f, 0x1d, 0xe6, 0xeb, 0x8e, 0xc, 0x4, 0x57, 0x48, 0x64, 0x23, 0x68, 0xb6, 0xef, 0xc2, 0x3b, 0xf9, 0x17, 0x8, 0x8e, 0x57, 0xb8, 0xb, 0xd8, 0x28, 0x6e, 0xd0, 0x7a, 0x3b, 0x48, 0x6a, 0x5d}, hash.Event{0x78, 0x7f, 0x9a, 0x82, 0xdf, 0x16, 0x42, 0x62, 0xef, 0x12, 0x1b, 0x8b, 0x86, 0xa5, 0xf8, 0x7a, 0xe9, 0xff, 0xe3, 0xc4, 0xe4, 0x5f, 0xc4, 0xa4, 0x0, 0xcc, 0xf3, 0xac, 0x34, 0x92, 0xe1, 0xdf}, hash.Event{0xda, 0x71, 0x16, 0x7, 0xb, 0xd2, 0xbc, 0x69, 0x5d, 0x6d, 0xf9, 0x2b, 0xdb, 0x12, 0x7d, 0x61, 0x1c, 0xc5, 0xa1, 0x0, 0xaf, 0x72, 0x60, 0x6e, 0xce, 0x7c, 0x9a, 0x70, 0x4, 0x6e, 0x2b, 0x9d}, hash.Event{0xb6, 0xa5, 0x8c, 0x71, 0xed, 0xea, 0x50, 0x2a, 0x0, 0x44, 0x71, 0xd6, 0xaf, 0x8d, 0x5d, 0x72, 0xba, 0x7, 0x4d, 0xd, 0x18, 0x85, 0x91, 0x71, 0xa, 0xd9, 0x13, 0xa1, 0x14, 0xfd, 0xd0, 0x38}, hash.Event{0x3, 0x19, 0x77, 0x4d, 0x4a, 0xc4, 0xd6, 0xad, 0xd3, 0x91, 0xd6, 0x52, 0xca, 0x4b, 0x82, 0x37, 0xb7, 0xaa, 0x2e, 0xff, 0xd7, 0x84, 0x58, 0x64, 0x4, 0xd, 0xab, 0x82, 0x52, 0x53, 0x12, 0x76}, hash.Event{0x91, 0xf0, 0x31, 0x92, 0x36, 0x60, 0x74, 0x4d, 0x5c, 0xed, 0xc1, 0x2, 0x6c, 0x41, 0x52, 0x37, 0x42, 0x6d, 0x2d, 0x15, 0x53, 0xca, 0x92, 0x29, 0xd7, 0xae, 0xfa, 0x8b, 0x8, 0x90, 0x58, 0x5d}}}
                                actual  : &posposet.Block{Index:0x1a, Events:hash.EventsSlice{hash.Event{0x2f, 0x1d, 0xe6, 0xeb, 0x8e, 0xc, 0x4, 0x57, 0x48, 0x64, 0x23, 0x68, 0xb6, 0xef, 0xc2, 0x3b, 0xf9, 0x17, 0x8, 0x8e, 0x57, 0xb8, 0xb, 0xd8, 0x28, 0x6e, 0xd0, 0x7a, 0x3b, 0x48, 0x6a, 0x5d}, hash.Event{0x78, 0x7f, 0x9a, 0x82, 0xdf, 0x16, 0x42, 0x62, 0xef, 0x12, 0x1b, 0x8b, 0x86, 0xa5, 0xf8, 0x7a, 0xe9, 0xff, 0xe3, 0xc4, 0xe4, 0x5f, 0xc4, 0xa4, 0x0, 0xcc, 0xf3, 0xac, 0x34, 0x92, 0xe1, 0xdf}, hash.Event{0xda, 0x71, 0x16, 0x7, 0xb, 0xd2, 0xbc, 0x69, 0x5d, 0x6d, 0xf9, 0x2b, 0xdb, 0x12, 0x7d, 0x61, 0x1c, 0xc5, 0xa1, 0x0, 0xaf, 0x72, 0x60, 0x6e, 0xce, 0x7c, 0x9a, 0x70, 0x4, 0x6e, 0x2b, 0x9d}, hash.Event{0xb6, 0xa5, 0x8c, 0x71, 0xed, 0xea, 0x50, 0x2a, 0x0, 0x44, 0x71, 0xd6, 0xaf, 0x8d, 0x5d, 0x72, 0xba, 0x7, 0x4d, 0xd, 0x18, 0x85, 0x91, 0x71, 0xa, 0xd9, 0x13, 0xa1, 0x14, 0xfd, 0xd0, 0x38}, hash.Event{0x3, 0x19, 0x77, 0x4d, 0x4a, 0xc4, 0xd6, 0xad, 0xd3, 0x91, 0xd6, 0x52, 0xca, 0x4b, 0x82, 0x37, 0xb7, 0xaa, 0x2e, 0xff, 0xd7, 0x84, 0x58, 0x64, 0x4, 0xd, 0xab, 0x82, 0x52, 0x53, 0x12, 0x76}}}

                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -2,3 +2,3 @@
                                  Index: (uint64) 26,
                                - Events: (hash.EventsSlice) (len=6) {
                                + Events: (hash.EventsSlice) (len=5) {
                                   (hash.Event) (len=32) a026,
                                @@ -7,4 +7,3 @@
                                   (hash.Event) (len=32) e026,
                                -  (hash.Event) (len=32) a027,
                                -  (hash.Event) (len=32) d026
                                +  (hash.Event) (len=32) a027
                                  }
                Test:           TestPoset/Check_consensus
                Messages:       block
FAIL
FAIL    github.com/Fantom-foundation/go-lachesis/src/posposet   6.443s
time="2019-06-06T15:08:04+10:00" level=warning msg="event d01 had received already, so rejected"
time="2019-06-06T15:08:04+10:00" level=warning msg="event e01 had received already, so rejected"
--- FAIL: TestPoset (6.68s)
    --- FAIL: TestPoset/Check_consensus (0.01s)
        poset_test.go:73: 
                Error Trace:    poset_test.go:73
                Error:          Not equal: 
                                expected: &posposet.Block{Index:0x43, Events:hash.EventsSlice{hash.Event{0x1a, 0xbb, 0x33, 0xc0, 0xb8, 0x29, 0x5a, 0xb4, 0xba, 0x61, 0x8d, 0x67, 0x63, 0xbb, 0xc5, 0xbe, 0x71, 0xa, 0xb5, 0xb1, 0xc1, 0xc0, 0xed, 0x26, 0xfe, 0x5e, 0x5b, 0x17, 0x69, 0xec, 0x87, 0xfc}, hash.Event{0xb6, 0xe0, 0xc2, 0xd6, 0x41, 0xf7, 0x39, 0xa9, 0x36, 0x38, 0xd9, 0x59, 0xfe, 0x46, 0x72, 0x39, 0x7d, 0x78, 0x46, 0x77, 0xcd, 0xe6, 0x7, 0xee, 0x7a, 0x9b, 0x2e, 0xdf, 0x6e, 0xbd, 0x96, 0xfe}, hash.Event{0x5c, 0x43, 0x6, 0xaf, 0xf3, 0x92, 0x23, 0x17, 0xf4, 0x48, 0x6c, 0xc, 0x75, 0x7, 0x7, 0xab, 0xda, 0x95, 0x8b, 0xc0, 0xf3, 0xe9, 0x6c, 0xe0, 0xd5, 0x46, 0x88, 0x18, 0xaf, 0xc5, 0xf0, 0xa4}, hash.Event{0x7e, 0x46, 0x65, 0xbd, 0xf0, 0x75, 0x63, 0xa6, 0x9f, 0xe0, 0x91, 0x75, 0xb8, 0x87, 0x90, 0x4d, 0x4, 0x38, 0x48, 0x41, 0xe9, 0xf5, 0x58, 0xc1, 0xed, 0x28, 0x51, 0x65, 0x68, 0x2, 0x55, 0xd3}, hash.Event{0xa3, 0xa, 0xe0, 0x27, 0xd7, 0xcf, 0x28, 0xd, 0x45, 0x81, 0x76, 0x12, 0xed, 0x50, 0x8c, 0xfb, 0xf0, 0xe7, 0x6b, 0x8d, 0x7c, 0x5, 0x9e, 0xf3, 0x61, 0x75, 0x0, 0xe5, 0xfc, 0x6f, 0xbc, 0x98}, hash.Event{0x6b, 0x47, 0xc8, 0xb6, 0x5d, 0x4c, 0xd3, 0xeb, 0x4a, 0x23, 0x86, 0x7c, 0x27, 0x7e, 0xb5, 0x9e, 0xc0, 0xc1, 0x26, 0x40, 0xd1, 0xd, 0xc, 0xc6, 0x33, 0xaf, 0x91, 0x97, 0xa0, 0xca, 0xea, 0x19}}}
                                actual  : &posposet.Block{Index:0x43, Events:hash.EventsSlice{hash.Event{0x1a, 0xbb, 0x33, 0xc0, 0xb8, 0x29, 0x5a, 0xb4, 0xba, 0x61, 0x8d, 0x67, 0x63, 0xbb, 0xc5, 0xbe, 0x71, 0xa, 0xb5, 0xb1, 0xc1, 0xc0, 0xed, 0x26, 0xfe, 0x5e, 0x5b, 0x17, 0x69, 0xec, 0x87, 0xfc}, hash.Event{0x5c, 0x43, 0x6, 0xaf, 0xf3, 0x92, 0x23, 0x17, 0xf4, 0x48, 0x6c, 0xc, 0x75, 0x7, 0x7, 0xab, 0xda, 0x95, 0x8b, 0xc0, 0xf3, 0xe9, 0x6c, 0xe0, 0xd5, 0x46, 0x88, 0x18, 0xaf, 0xc5, 0xf0, 0xa4}, hash.Event{0x7e, 0x46, 0x65, 0xbd, 0xf0, 0x75, 0x63, 0xa6, 0x9f, 0xe0, 0x91, 0x75, 0xb8, 0x87, 0x90, 0x4d, 0x4, 0x38, 0x48, 0x41, 0xe9, 0xf5, 0x58, 0xc1, 0xed, 0x28, 0x51, 0x65, 0x68, 0x2, 0x55, 0xd3}, hash.Event{0xb6, 0xe0, 0xc2, 0xd6, 0x41, 0xf7, 0x39, 0xa9, 0x36, 0x38, 0xd9, 0x59, 0xfe, 0x46, 0x72, 0x39, 0x7d, 0x78, 0x46, 0x77, 0xcd, 0xe6, 0x7, 0xee, 0x7a, 0x9b, 0x2e, 0xdf, 0x6e, 0xbd, 0x96, 0xfe}}}

                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -2,9 +2,7 @@
                                  Index: (uint64) 67,
                                - Events: (hash.EventsSlice) (len=6) {
                                + Events: (hash.EventsSlice) (len=4) {
                                   (hash.Event) (len=32) c072,
                                -  (hash.Event) (len=32) c073,
                                   (hash.Event) (len=32) d072,
                                   (hash.Event) (len=32) e072,
                                -  (hash.Event) (len=32) a073,
                                -  (hash.Event) (len=32) b073
                                +  (hash.Event) (len=32) c073
                                  }
                Test:           TestPoset/Check_consensus
                Messages:       block
FAIL
FAIL    github.com/Fantom-foundation/go-lachesis/src/posposet   6.948s

To Reproduce run make test 2>&1 | tee 00-tests.log several times until this failure happens.

Expected behavior The test should either fails in 100% runs, either pass in 100% runs.

devintegral commented 4 years ago

outdated