search

Fantom-foundation / go-lachesis

aBFT consensus for permission-less networks
https://fantom.foundation
MIT License
223 stars 78 forks source link

Fix stohastic method for choise parent events #497

Closed ghost closed 4 years ago

ghost commented 4 years ago

Deep optimization for stochastic method choice parent events for DAG. Faster in 150 times then "Weighted Permutation".

codecov-commenter commented 4 years ago

Codecov Report

Merging #497 into develop will decrease coverage by 0.14%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #497      +/-   ##
===========================================
- Coverage    47.08%   46.94%   -0.15%     
===========================================
  Files          193      193              
  Lines        13989    14015      +26     
===========================================
- Hits          6587     6579       -8     
- Misses        6827     6862      +35     
+ Partials       575      574       -1
Impacted Files Coverage Δ
utils/permutation.go 76.47% <100.00%> (+0.71%) :arrow_up:
utils/roulette.go 0.00% <0.00%> (-100.00%) :arrow_down:
cmd/lachesis/export.go 0.00% <0.00%> (ø)
cmd/lachesis/import.go 0.00% <0.00%> (ø)
gossip/consensus_callbacks.go 11.29% <0.00%> (+1.47%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cc56a55...6c570cb. Read the comment docs.

devintegral commented 4 years ago

StochasticPermutation() ignores size arg. So, is not for production, research only.