Fantom-foundation / go-lachesis

aBFT consensus for permission-less networks
https://fantom.foundation
MIT License
223 stars 78 forks source link

Hotfix: topicsdb memory leak #581

Closed rus-alex closed 3 years ago

rus-alex commented 3 years ago

Makes logrecBuilder.ready channel buffered, so goroutines don't stuck on sending result even if no receivers.

codecov-io commented 3 years ago

Codecov Report

Merging #581 (8dcbd5b) into develop2 (ad65fb7) will decrease coverage by 0.11%. The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop2     #581      +/-   ##
============================================
- Coverage     47.94%   47.82%   -0.12%     
============================================
  Files           161      161              
  Lines         10917    10916       -1     
============================================
- Hits           5234     5221      -13     
- Misses         5155     5166      +11     
- Partials        528      529       +1     
Impacted Files Coverage Δ
topicsdb/search_async.go 65.38% <50.00%> (-4.43%) :arrow_down:
inter/ascii_scheme.go 80.00% <0.00%> (-3.18%) :arrow_down:
cmd/lachesis/params.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad65fb7...8dcbd5b. Read the comment docs.