Fantom-foundation / go-lachesis

aBFT consensus for permission-less networks
https://fantom.foundation
MIT License
220 stars 77 forks source link

Limit on grpc message size #62

Closed Maxime2 closed 6 years ago

Maxime2 commented 6 years ago

I have tried lachesis version after https://github.com/andrecronje/lachesis/pull/59 with CI/CD check script scripts/multi.bash and got a bunch of errors like these:

WARN[0036] recv from server err: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (48900172 vs. 4194304) WARN[0036] recv from server err: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (48900172 vs. 4194304) WARN[0036] recv from server err: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (48900172 vs. 4194304)

it looks like we are hitting here the default MaxReceiveMessageSize limitation in grpc: https://github.com/grpc/grpc-go/blob/master/clientconn.go#L96

Perhaps we need add limitation on block size in lachesis to fit inside this limit.

devintegral commented 6 years ago

I hope, that error will disappear after the PR #65 merged.