search

Fapiko / intellij-better-direnv

Apache License 2.0
30 stars 18 forks source link

python support #3

Closed sertaco closed 2 years ago

sertaco commented 2 years ago

Python support much appreciated.

If you can show some pointers, I can give it a try too

Fapiko commented 2 years ago

Hey @sertaco - I think Python support should be fairly straightforward, I've just been swamped for the past month or so.

If you take a look at how the EnvFile plugin is handling it https://github.com/ashald/EnvFile/blob/develop/modules/products/pycharm/src/main/java/net/ashald/envfile/products/pycharm/PyCharmRunConfigurationExtension.java should give a baseline for how to adapt this plugin.

The trickiest part for me was probably the build system if you're not super familiar with Gradle (I mostly used maven when I was doing Java development on a daily basis). If you take a look at this PR diff you can see the changes I made to integrate with Go and Node run configs: https://github.com/Fapiko/intellij-better-direnv/commit/6aaaea87a418338ee3870f852d2195a5db2d85cb#diff-c0dfa6bc7a8685217f70a860145fbdf416d449eaff052fa28352c5cec1a98c06

jfreela commented 2 years ago

Just pushed a PR for this - https://github.com/Fapiko/intellij-better-direnv/pull/6

Fapiko commented 2 years ago

This is in the latest release 0.3.0 - should be verified and available in a day or two.

sertaco commented 2 years ago

I had a chance to try 0.3.0 today and could not make it work. Did anyone use Python direnv succesfully?

Fapiko commented 2 years ago

I'm actually noticing that this doesn't work on versions 2022.2 and newer, but does on 2022.1. So something has changed with the Python plugin execution path.

jfreela commented 2 years ago

Added PR to address broken Python support in IDEA 2022.2+

https://github.com/Fapiko/intellij-better-direnv/pull/9

sertaco commented 2 years ago

perfect! works as expected for 2022.2.1! thanks