search

FaradayInstitution / BPX

BPX schema in pydantic and JSON schema format, and parsers
MIT License
25 stars 12 forks source link

Fix maximum concentration in positive electrode in test file #31

Closed ikorotkin closed 1 year ago

ikorotkin commented 1 year ago

It was not actually a bug; the maximum concentrations in the test files can be arbitrary. The test only checks that the initial concentrations calculated from the provided maximum concentrations and the target SOC are correct.

Still, I have updated the maximum concentration in the test as suggested in issue #30 and updated the initial concentration test accordingly. This fix serves as a quick example for me to set up and test the workflow to address other issues in the project.

rtimms commented 1 year ago

Looks, good thanks! Can you make the PR to the new develop branch?

ikorotkin commented 1 year ago

Changed the base branch for this PR from main to develop.