Closed ikorotkin closed 1 year ago
:exclamation: No coverage uploaded for pull request base (
develop@804d758
). Click here to learn what that means. Patch has no changes to coverable lines.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
A (working) attempt to add validation based on the model according to issue #29 and following roadmap #22.
This PR is based on #33 and supports blended electrodes for all models.
Added multiple tests and validation that the given model (SPM, SPMe, or DFN) corresponds to a proper parameter set. In the case of SPM, some of the parameters should not be included:
Note if we change the
Model
field toDFN
orSPMe
in this example, this will produce an error. Also note how we defined blended electrode (positive in this example). Some of the parameters are optional.