search

FaradayInstitution / BPX

BPX schema in pydantic and JSON schema format, and parsers
MIT License
25 stars 12 forks source link

Temporarily pin `pydantic<2` to fix PyBaMM build #35

Closed arjxn-py closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (ef0b524) 96.49% compared to head (4679e27) 96.49%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #35 +/- ## ======================================= Coverage 96.49% 96.49% ======================================= Files 9 9 Lines 257 257 ======================================= Hits 248 248 Misses 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

agriyakhetarpal commented 1 year ago

Should Python 3.11 be added to the CI matrix too?

I have been trying to add updates and breaking changes for Pydantic V2. The new version also carries over a backport of Pydantic V1 so we can import older functionality and implement newer changes incrementally

rtimms commented 1 year ago

Thanks @arjxn-py, will merge this now!

@agriyakhetarpal yes, let's add 3.11. If you see anything that could be improved on the CI then please go ahead and make a PR.