search

FaradayInstitution / BPX

BPX schema in pydantic and JSON schema format, and parsers
MIT License
23 stars 12 forks source link

Simplify specification of active material content #41

Open ejfdickinson opened 10 months ago

ejfdickinson commented 10 months ago

[...] I think it's an irritation of the present BPX that it's necessary to define the mass loading of active components indirectly, via the specification of a surface area and a particle radius combined with the assumption of spherical particles.

I think it would be more comprehensible to be able (optionally) to introduce some ability to specify e.g. a mass fraction and corresponding specific capacity of each blend component, and make the active volumetric surface area a dependent quantity under the equivalent spherical particle assumption.

Originally posted by @ejfdickinson in https://github.com/pybamm-team/BPX/issues/33#issuecomment-1598516406

ejfdickinson commented 10 months ago

@ejfdickinson totally agree with your comment about mass loading. It feels backwards at the moment. I think we should specify the active material volume fraction directly. In your experience, what do you think is actually the most sensible set of parameters to specify from an experimental point of view? The current standard is very much from the model POV and I think it might be more useful to approach it from the other direction.

Originally posted by @rtimms in https://github.com/pybamm-team/BPX/issues/33#issuecomment-1598562147