FaradayInstitution / BPX

BPX schema in pydantic and JSON schema format, and parsers
MIT License
25 stars 12 forks source link

Add parametrisation examples #45

Closed ikorotkin closed 11 months ago

ikorotkin commented 1 year ago

Added 5 parametrisation examples:

From the email chain:

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@679e153). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #45 +/- ## ========================================== Coverage ? 97.07% ========================================== Files ? 9 Lines ? 308 Branches ? 0 ========================================== Hits ? 299 Misses ? 9 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ejfdickinson commented 1 year ago

@ikorotkin @rtimms

I disagree with the suggestion to restrict what BPX users can call the components of a blended electrode for the following reasons: