FaradayInstitution / BPX

BPX schema in pydantic and JSON schema format, and parsers
MIT License
22 stars 12 forks source link

Remove thermal conductivity from BPX schema #50

Open ejfdickinson opened 7 months ago

ejfdickinson commented 7 months ago

spotted by @ikorotkin

The BPX schema includes a field ["Parameterisation"]["Cell"]["Thermal conductivity [W.m-1.K-1]"]. However, this parameter is not defined or used in the corresponding mathematical specification for any model.

Proposed fix:

Recommended to fix after v0.4 release.

rtimms commented 7 months ago

Thanks! On your points: