search

FaradayInstitution / BPX

BPX schema in pydantic and JSON schema format, and parsers
MIT License
23 stars 12 forks source link

Define a specific supported equation set for SPMe #59

Open ejfdickinson opened 3 weeks ago

ejfdickinson commented 3 weeks ago

Add to the BPX standard a specifically defined equation set for "SPMe", within which the BPX parameters are used.

This will require some discussion on whether the PyBaMM implementation is appropriate, or if the canonical SPMe defined by Marquis 2019 should be used. See also https://github.com/pybamm-team/PyBaMM/issues/4145

valentinsulzer commented 3 weeks ago

I would push towards using the PyBaMM implementation (with better documentation) as this is the more "practically accurate" version, compared to the "mathematically accurate" version from Marquis