search

FaradayRF / Faraday-Software

Faraday node software
https://www.faradayrf.com
Other
48 stars 19 forks source link

Adding GREEN LED RX functionality for #232 #242

Closed markwiem closed 7 years ago

markwiem commented 7 years ago

Created new branch due to suspect Fast-Forward issue in my repo of the original issue232 branch. Changes need review, but should mirror those of issue232 branch.

I recommend we close the original issue232 branch: https://github.com/FaradayRF/Faraday-Software/pull/238#pullrequestreview-48692970

kb1lqd commented 7 years ago

@markwiem did you forget one of these two?

https://github.com/FaradayRF/Faraday-Software/pull/238#pullrequestreview-48692970

markwiem commented 7 years ago

@kb1lqd I may be missing something, but I feel I've made the required changes.

From the original PR "bootbitmask[5] should be bootbitmask[2]" is satisfied in line 146 of simpleconfig.py

and

"bootmask[2]. should be bootmask[5]" is satisfied in line 241 of deviceconfiguration.py

Please let me know if I'm still mistaken. Thanks!

markwiem commented 7 years ago

Awesome! Absolutely made my day! Onward to conquer new mountains! ⛰