search

Farama-Foundation / Arcade-Learning-Environment

The Arcade Learning Environment (ALE) -- a platform for AI research.
https://ale.farama.org/
GNU General Public License v2.0
2.14k stars 420 forks source link

Python 3 support? #139

Closed xgdgsc closed 8 years ago

xgdgsc commented 8 years ago

Currently I have to modify the print function in setup.py to install, I haven' t tested whether it can be used with python 3. Is there python 3 support for now?

pierrelux commented 8 years ago

Yes beside that, just make sure to prefix the setting strings with "b". For example: ale.setBool(b'color_averaging', True)

bbitmaster commented 8 years ago

In addition, I could not get the ale_python_interface to install using setup.py in python 3. It seemed to install, but the symbols were missing from the import. The fix was to change the init.py file to contain: from ale_python_interface.ale_python_interface import *

mgbellemare commented 8 years ago

@mhauskn , can you weigh in?

pierrelux commented 8 years ago

@bbitmaster I run my code with from ale_python_interface import ale_python_interface as ALE

mhauskn commented 8 years ago

@mgbellemare I haven't gotten around to testing/building with Python 3 yet. It's definitely something ALE should support so, I'd be happy to look into it over the next few days.

marcgb commented 8 years ago

@xgdgsc @mhauskn does pull request #145 address this issue?

mhauskn commented 8 years ago

Yes, it does.

On Fri, Feb 12, 2016 at 7:44 AM, marcgb notifications@github.com wrote:

@xgdgsc https://github.com/xgdgsc @mhauskn https://github.com/mhauskn does pull request #145 https://github.com/mgbellemare/Arcade-Learning-Environment/pull/145 address this issue?

— Reply to this email directly or view it on GitHub https://github.com/mgbellemare/Arcade-Learning-Environment/issues/139#issuecomment-183335375 .

mgbellemare commented 8 years ago

Fixed by #145.