Farama-Foundation / Arcade-Learning-Environment

The Arcade Learning Environment (ALE) -- a platform for AI research.
https://ale.farama.org/
GNU General Public License v2.0
2.18k stars 424 forks source link

Minimal action set is wrong #179

Closed rubenvereecken closed 8 years ago

rubenvereecken commented 8 years ago

When trying the ROM Video Game Olympics on ALE 0.5.1, I get the wrong action set. In fact, I get the action set for Space Invaders, another game I use frequently.

I verified it indeed runs the ROM I intended it to:

  Cart Name: Video Olympics (1978) (Atari)

The reported actions are [ 0 1 3 4 11 12], which should really just be [ 0 3 4] which I do get on another machine on ALE 0.5.0.

mgbellemare commented 8 years ago

The fire button is in fact used in Video Game Olympics ('pong.bin'), hence the three extra actions. See manual at

https://atariage.com/software_page.html?SoftwareID=1434

rubenvereecken commented 8 years ago

Huh, cool, thanks for that. So what makes my other and older ALE detect the wrong action set? Either way, I guess it's probably fixed in the newer version. If so, this can be closed.

mgbellemare commented 8 years ago

Yes, this is a fairly recent fix. You don't need the fire button for perfect play in the deterministic version, hence the oversight.