search

Farama-Foundation / Arcade-Learning-Environment

The Arcade Learning Environment (ALE) -- a platform for AI research.
https://ale.farama.org/
GNU General Public License v2.0
2.18k stars 424 forks source link

Missing checksums for new game ROMs #336

Closed jkterry1 closed 4 years ago

jkterry1 commented 4 years ago

@tkoeppe The 30 new games you added didn't get MD5s for them added to the list: https://github.com/mgbellemare/Arcade-Learning-Environment/blob/master/md5.txt

This is needed to verify you're using the right ROM for the code. Can you please look into this?

jkterry1 commented 4 years ago

It turns out all the relevant md5s checksums are already in here, but elsewhere?

https://github.com/mgbellemare/Arcade-Learning-Environment/blob/master/src/emucore/stella.pro

tkoeppe commented 4 years ago

I'll see that we collect those checksums; but the verification is not fatal, right?

jkterry1 commented 4 years ago

It's not fatal. Someone who works with me also submitted a PR for this- #338